Volumes Of Fun
http://www.volumesoffun.com/phpBB3/

[Resolved]: Some g++ 4.6 fixes
http://www.volumesoffun.com/phpBB3/viewtopic.php?f=15&t=239
Page 1 of 1

Author:  HolgerSchurig [ Fri Jul 01, 2011 9:14 am ]
Post subject:  [Resolved]: Some g++ 4.6 fixes

When I compile PolyVox using g++ 4.6 and "-Wall -Wextra" (always a good idea) I get a bunch of warnings.

GradientEstimators.h contains a "#pragma" that g++ warns about. I think this pragma is entirely useless regarding code generation, so it can go.

SurfaceMesh.h / SurfaceMesh.inl contain a function "isEmpty()" which returns a "const bool". g++ warns about this, "bool" as return type is enought. As it is neither a reference nor a pointer, defining constness on it is a bit weird indeed.

AStarPathfinderImpl.h defines the member variables parent, gVal, hVal in this order. But the constructor initializes them in another order, which produces a warning as well. The cure is easy: make definition and initialization order the same.

Attachments:
fixes.patch [1.98 KiB]
Downloaded 243 times

Author:  David Williams [ Fri Jul 01, 2011 9:58 pm ]
Post subject:  Re: Some g++ 4.6 fixes

Thanks, I've applied all your fixes.

HolgerSchurig wrote:
GradientEstimators.h contains a "#pragma" that g++ warns about. I think this pragma is entirely useless regarding code generation, so it can go.


In Visual Studio this #pragma is used for custom code folding. There used to be lots of them, but I didn't really use the feature and they generatd GCC warnings so I took them out. Seems I missed one.

Page 1 of 1 All times are UTC
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
http://www.phpbb.com/