[Closed] Shift on native integer type, can overflow if...

realazthat · **Joined:** Wed Apr 27, 2011 7:10 am **Posts:** 43

https://gitorious.org/polyvox/polyvox/b ... r.h#line79

Code:

                static DensityType getThreshold() throw() {return  0x01 << (NoOfDensityBits - 1);}

It should probably be:

Code:

                static DensityType getThreshold() throw() {return  DensityType(0x01) << (NoOfDensityBits - 1);}

Similar examples should probably be fixed as well. If a unit test is made, it should try a few different types including some larger (64 bit) types.

David Williams · **Joined:** Sun May 04, 2008 6:35 pm **Posts:** 1827

You're probably right, but these functions are actually removed in the Git version of PolyVox. Deciding whether a voxel is above/below a threshold will be performed via some kind of callback so that the primitive types (including floats, where the shifting makes no sense) can be used as well as the predefined voxel types.

Details are in this thread: viewtopic.php?p=2711#p2711

Thanks anyway!

[Closed] Shift on native integer type, can overflow if...

Who is online