My last patches made the compilation in the library/ subdirectory warning free. With this bunch of patches, all get's warning free, .e.g. even the examples.
glew.cpp contains a check "glXGetClientString == NULL". However, this can never be the cast, as this is defined in glew.h as "extern const char* glXGetClientString (Display *dpy, int name);". g++ 4.6 warns "can never be NULL".
I also noticed that there are 4 identical glew/ subdirectories now in the code base.
examples/Paging/main.cpp: the callback function unload() doesn't use the parameter "vol". "Q_UNUSED(vol)" or "(void)vol" will make the compiler not spit out an unused parameter warning.
library/PolyVoxCore/include/PolyVoxCore/CubicSurfaceExtractorWithNormals.inl in the CubicSurfaceExtractorWithNormals constructor: initialization order, m_meshCurrent must be initialized before m_regSizeInVoxels.
library/PolyVoxCore/include/PolyVoxCore/LargeVolume.inl: directly at the end of a for loop there's the code "Block<VoxelType>* block = getUncompressedBlock(x,y,z);". This produces an unused variable warning. I haven't looked if getUncompressedBlock() is called because of a side effect or not. If not, then this line can vanish. In the other case, the "Block<VoxelType>* block =" can vanish. If this produces a warning on other compiler, then "(void) getUncompressedBlock(x,y,z)" can be used, probably with a comment to hint to the side-effect.
library/PolyVoxCore/include/PolyVoxCore/SimpleVolumeBlock.inl: in the SimpleVolume constructor, the initizalization order for m_uSideLength and m_tUncompressedData doesn't match the header file.
examples/Paging/Perlin.cpp: there are two lines "float freq = mFrequency;" in this file where the variable isn't used.
library/PolyVoxCore/include/PolyVoxCore/Vector.inl: in the for loop "for(int ct = 0; ct < Size; ++ct)" the variable Size is unsigned, while "int ct" makes it signed. Chaning "int" to "uint32_t" (the type of Size) get's rid of the sign-comparison mismatch warning.
library/PolyVoxCore/include/PolyVoxCore/AStarPathfinder.h: in the constructor of AStarPathfinderParamsM the initialization order of hBias and isVoxelValidForPath doesn't match the variable ordering.
library/PolyVoxCore/include/PolyVoxCore/MeshDecimator.inl: the method "performDecimationPass" get's called with a parameter m_fMinDotProductForCollapse, which is never used.
In the same file, the method "canCollapseMaterialEdge" get's called with two parameters, which are both unused. I actually wonder if this method should vanish completely, it doesn't seem used.
library/PolyVoxCore/include/PolyVoxCore/Raycast.inl: in the Raycast constructor, the initialization order of m_result doesn't match the order of the header file.
library/PolyVoxCore/include/PolyVoxCore/SurfaceExtractor.inl: the method generateIndicesForSlice() doesn't use it's last parameter "m_pCurrentVertexIndicesZ".
examples/OpenGL/OpenGLWidget.cpp: the "wheelEvent" doesn't use it's parameter "wheel", I suggest a Q_UNUSED(wheel) here. I haven't looked in detail, maybe the method can go away completely.
library/PolyVoxCore/include/PolyVoxCore/AmbientOcclusionCalculator.inl: the three local variables "iRatioMax", "fRatioMax" and "fHalfRatioMax" are unused.
I again attached a patch.
| Attachments: |
fix-warnings.patch [9.03 KiB]
Downloaded 222 times |